Skip to content

Fix: Support 16KB page sizes and update core dependencies.#108

Open
alfiebaxter04 wants to merge 1 commit intoandroid:mainfrom
alfiebaxter04:fix/issue99
Open

Fix: Support 16KB page sizes and update core dependencies.#108
alfiebaxter04 wants to merge 1 commit intoandroid:mainfrom
alfiebaxter04:fix/issue99

Conversation

@alfiebaxter04
Copy link
Contributor

@alfiebaxter04 alfiebaxter04 commented Mar 4, 2026

This PR updates the build configuration and dependencies to support 16KB page sizes.

Fixes #99

@gemini-code-assist
Copy link
Contributor

gemini-code-assist bot commented Mar 4, 2026

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the AGDK Tunnel sample application to support 16KB page sizes, addressing a specific issue. It achieves this by upgrading the NDK version and several key AndroidX and Google Play Games dependencies, alongside necessary adjustments to the CMake build configuration to incorporate the new page size linker option and updated library references.

Highlights

  • NDK Version Update: The NDK version in build.gradle has been updated to 28.0.12674087.
  • Dependency Upgrades: Several core dependencies, including Oboe, Games Frame Pacing, and Play Services Games v2 Native C, have been upgraded to their latest versions.
  • CMakeLists.txt Modifications: The CMakeLists.txt file was updated to reflect the new Play Services Games v2 C library and to include a linker option for 16KB page size support.
  • 16KB Page Size Support: A linker option (-Wl,-z,max-page-size=16384) has been added to CMakeLists.txt to enable support for 16KB page sizes.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • agdk/agdktunnel/app/build.gradle
    • Updated ndkVersion from 27.2.12479018 to 28.0.12674087.
    • Upgraded oboe from 1.5.0 to 1.10.0.
    • Upgraded games-frame-pacing from 2.1.2 to 2.1.3.
    • Replaced play-services-gni-native-c:1.0.0-beta2 with play-services-games-v2-native-c:21.0.0-beta1.
  • agdk/agdktunnel/app/src/main/cpp/CMakeLists.txt
    • Updated find_package from com.google.android.gms.gni.c to com.google.android.gms.games.v2.c.
    • Updated target_link_libraries from com.google.android.gms.gni.c::gni_shared to com.google.android.gms.games.v2.c::games_static.
    • Added target_link_options with "-Wl,-z,max-page-size=16384" to enable 16KB page size support.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

gemini-code-assist[bot]
gemini-code-assist bot reviewed Mar 4, 2026
View reviewed changes
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request successfully updates core dependencies, including the NDK version and several Android Game SDK libraries, to support 16KB page sizes. The migration from 'play-services-gni-native-c' to 'play-services-games-v2-native-c' is reflected across both Gradle and CMake configurations. The addition of the 'max-page-size' linker option directly addresses the requirement for 16KB page size support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Incompatible with 16KB alignment

1 participant

@alfiebaxter04